Skip to content

Hardwaretimer analogWrite() no glitch #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2020
Merged

Hardwaretimer analogWrite() no glitch #941

merged 2 commits into from
Feb 17, 2020

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Feb 17, 2020

Summary

  • HardwareTimer: Add API to get configured mode
  • analogWrite: Configure HardwareTimer mode only if not previously done
    This avoid glitch when calling analoWrite multiple time.
    Also don't start again timer otherwise ther is also some glitches

Fixes #939

@ABOSTM
HardwareTimer: Add API to get configured mode
f28dc09
@ABOSTM
analogWrite: Configure HardwareTimer mode only if not previously done
bdcc98e 
This avoid glitch when calling analoWrite multiple time.
Also don't start again timer otherwise ther is also some glitches

Fixes stm32duino#939
@ABOSTM ABOSTM mentioned this pull request Feb 17, 2020
Closed
@fpistm fpistm added the enhancement New feature or request label Feb 17, 2020
@fpistm fpistm self-requested a review February 17, 2020 16:11
fpistm
fpistm approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting @ktand feedback before merge.

@fpistm fpistm added this to the 1.9.0 milestone Feb 17, 2020
ktand
ktand approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@ktand ktand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fpistm fpistm merged commit f1d475a into stm32duino:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktand ktand ktand approved these changes

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Calling analogWrite multiple times causes glitches in PWM signal
3 participants
@ABOSTM @ktand @fpistm